Update wiremock and jetty#46
Merged
YANG-DB merged 3 commits intoopensearch-project:mainfrom Jan 5, 2023
Merged
Conversation
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Update `wiremock` and `jetty`.
YANG-DB
approved these changes
Jan 5, 2023
Collaborator
Author
|
@YANG-DB can you please add backport label? |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-46-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d932fba740f73dc6bb0b6e87d3ebbfbf66fe4900
# Push it to GitHub
git push --set-upstream origin backport/backport-46-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
Yury-Fridlyand
added a commit
to Bit-Quill/sql-jdbc
that referenced
this pull request
Jan 5, 2023
6 tasks
YANG-DB
pushed a commit
that referenced
this pull request
Jan 5, 2023
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit d932fba) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yury-Fridlyand yury.fridlyand@improving.com
Description
Update
wiremockandjettywhichwiremockdepends on.Wiremock release: https://github.com/wiremock/wiremock/releases/tag/3.0.0-beta-2
Maven: https://mvnrepository.com/artifact/com.github.tomakehurst/wiremock/3.0.0-beta-2
Previous update: opensearch-project/sql#872
Newer
jettyactivates SNI check, so I had to disable it, ref: https://github.com/Bit-Quill/sql-jdbc/blob/c3a79b79d58665d8fd3b69167c9a8fa9601a0467/src/test/java/org/opensearch/jdbc/test/TLSServer.java#L88-L90Issues Resolved
Closes #7 and #8
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.